Fix airflow tests #3262
Merged
Fix airflow tests #3262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin Su <[email protected]>
pingsutw
requested review from
cosmicBboy,
davidmirror-ops,
eapolinario,
kumare3,
samhita-alla and
wild-endeavor
as code owners
wild-endeavor
previously approved these changes
Jun 3, 2025
Signed-off-by: Kevin Su <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3262 +/- ##
==========================================
+ Coverage 74.71% 75.64% +0.92%
==========================================
Files 276 215 -61
Lines 25020 22488 -2532
Branches 2953 2954 +1
==========================================
- Hits 18693 17010 -1683
+ Misses 5491 4606 -885
- Partials 836 872 +36 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
wild-endeavor
approved these changes
Jun 3, 2025
Atharva1723
pushed a commit
to Atharva1723/flytekit
that referenced
this pull request
Oct 5, 2025
Signed-off-by: Kevin Su <[email protected]> Signed-off-by: Atharva <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
NA
Why are the changes needed?
unit test is failing
What changes were proposed in this pull request?
Add the uppoer bound for sqlalchemy-spanner
How was this patch tested?
unit test
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link
Summary by Bito
This pull request resolves a failing unit test by modifying the setup.py file to include an upper bound for the sqlalchemy-spanner dependency, ensuring compatibility and stability in the testing environment and successful unit test execution.