add FlyteRemote.deactivate_launchplan #3264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Niels Bantilan <[email protected]>
cosmicBboy
requested review from
davidmirror-ops,
eapolinario,
kumare3,
pingsutw,
samhita-alla and
wild-endeavor
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3264 +/- ##
===========================================
+ Coverage 74.71% 93.70% +18.99%
===========================================
Files 276 81 -195
Lines 25020 3497 -21523
Branches 2953 0 -2953
===========================================
- Hits 18693 3277 -15416
+ Misses 5491 220 -5271
+ Partials 836 0 -836 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pingsutw
approved these changes
Jun 5, 2025
Atharva1723
pushed a commit
to Atharva1723/flytekit
that referenced
this pull request
Oct 5, 2025
Signed-off-by: Niels Bantilan <[email protected]> Signed-off-by: Atharva <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
We have a
FlyteRemote.activate_launchplanconvenience method, but there's no way to deactivate a launch plan from a remote object.What changes were proposed in this pull request?
Adds a
deactivate_launchplanto theFlyteRemoteclassHow was this patch tested?
Tested on local sandbox
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link
Summary by Bito
This pull request adds a new method, `deactivate_launchplan`, to the `FlyteRemote` class, enabling users to deactivate launch plans. This enhancement fills a gap in functionality alongside the existing activation method. Local tests were conducted to verify its proper operation.