Skip to content

[Core feature] Task retry support in Flyte Connectors #3265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pingsutw merged 4 commits into from
Sep 17, 2025
Merged

[Core feature] Task retry support in Flyte Connectors #3265

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
464aa9a
feat: make internal error retryable
machichima Jun 6, 2025
61fd572
Merge branch 'master' of github.com:flyteorg/flytekit into 6465-conne…
machichima Sep 17, 2025
2a4df52
fix: internal error should be retryable failed
machichima Sep 17, 2025
512e07e
test: try fixing asyncio CI test fail
machichima Sep 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion flytekit/extend/backend/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,10 @@ def convert_to_flyte_phase(state: str) -> TaskExecution.Phase:
Convert the state from the connector to the phase in flyte.
"""
state = state.lower()
if state in ["failed", "timeout", "timedout", "canceled", "cancelled", "skipped", "internal_error"]:
if state in ["failed", "timeout", "timedout", "canceled", "cancelled", "skipped"]:
return TaskExecution.FAILED
if state in ["internal_error"]:
return TaskExecution.RETRYABLE_FAILED
elif state in ["done", "succeeded", "success", "completed"]:
return TaskExecution.SUCCEEDED
elif state in ["running", "terminating"]:
Expand Down
2 changes: 1 addition & 1 deletion tests/flytekit/unit/extend/test_connector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,7 +383,7 @@ def test_convert_to_flyte_phase():
assert convert_to_flyte_phase("TIMEDOUT") == TaskExecution.FAILED
assert convert_to_flyte_phase("CANCELED") == TaskExecution.FAILED
assert convert_to_flyte_phase("SKIPPED") == TaskExecution.FAILED
assert convert_to_flyte_phase("INTERNAL_ERROR") == TaskExecution.FAILED
assert convert_to_flyte_phase("INTERNAL_ERROR") == TaskExecution.RETRYABLE_FAILED

assert convert_to_flyte_phase("DONE") == TaskExecution.SUCCEEDED
assert convert_to_flyte_phase("SUCCEEDED") == TaskExecution.SUCCEEDED
Expand Down
6 changes: 2 additions & 4 deletions tests/flytekit/unit/utils/test_rate_limiter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,7 @@ async def helper_for_async(rpm: int, total: int):


def runner_for_async(rpm: int, total: int):
loop = asyncio.get_event_loop()
return loop.run_until_complete(helper_for_async(rpm, total))
return asyncio.run(helper_for_async(rpm, total))
Copy link
Member Author

@machichima machichima Sep 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create a fresh event loop each time and prevent using existing event loop. This fixes the CI test fail: https://github.com/flyteorg/flytekit/actions/runs/17783377366/job/50554009811



@pytest.mark.asyncio
Expand All @@ -43,8 +42,7 @@ async def helper_for_sync(rpm: int, total: int):


def runner_for_sync(rpm: int, total: int):
loop = asyncio.get_event_loop()
return loop.run_until_complete(helper_for_sync(rpm, total))
return asyncio.run(helper_for_sync(rpm, total))


@pytest.mark.asyncio
Expand Down