enable notebook task/workflow registration #3275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Niels Bantilan <[email protected]>
cosmicBboy
requested review from
davidmirror-ops,
eapolinario,
kumare3,
pingsutw,
samhita-alla and
wild-endeavor
as code owners
Signed-off-by: Niels Bantilan <[email protected]>
* updates * makes sense now Signed-off-by: Yee Hing Tong <[email protected]> --------- Signed-off-by: Yee Hing Tong <[email protected]>
cosmicBboy
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3275 +/- ##
==========================================
- Coverage 83.35% 76.06% -7.30%
==========================================
Files 347 215 -132
Lines 28791 22528 -6263
Branches 2960 2964 +4
==========================================
- Hits 23999 17135 -6864
- Misses 3956 4519 +563
- Partials 836 874 +38 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
wild-endeavor
approved these changes
Jun 23, 2025
Atharva1723
pushed a commit
to Atharva1723/flytekit
that referenced
this pull request
Oct 5, 2025
* [wip] enable notebook registration Signed-off-by: Niels Bantilan <[email protected]> * lint Signed-off-by: Niels Bantilan <[email protected]> * updates (flyteorg#3276) * updates * makes sense now Signed-off-by: Yee Hing Tong <[email protected]> --------- Signed-off-by: Yee Hing Tong <[email protected]> --------- Signed-off-by: Niels Bantilan <[email protected]> Signed-off-by: Yee Hing Tong <[email protected]> Co-authored-by: Yee Hing Tong <[email protected]> Signed-off-by: Atharva <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Currently, registering tasks, workflows, and launchplans via notebooks doesn't work. This is because uploading the pickle-serialized task functions only happens in the
execute_local_*methods.What changes were proposed in this pull request?
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link
Summary by Bito
This pull request enhances the registration process for tasks, workflows, and launch plans by introducing serialization of task functions in interactive mode. It prevents duplicate workflows, improving workflow management, and adds a caching mechanism for optimized retrieval of pickled target dictionaries. Additionally, it resolves previous issues with notebook-based task registration.