updates #3276
updates #3276
Conversation
|
Bito Automatic Review Skipped - Branch Excluded |
| *FlyteRemote._get_pod_template_hash(entity), | ||
| ) | ||
|
|
||
| if self.interactive_mode_enabled: |
There was a problem hiding this comment.
why remove these? won't this pickle and upload for non-fast registered tasks and workflows?
flytekit/remote/remote.py
Outdated
| if isinstance(entity, ArrayNode): | ||
| # extract WorkflowBase from ArrayNode | ||
| entity = entity.target.workflow | ||
| # if isinstance(entity, ArrayNode): |
There was a problem hiding this comment.
this is necessary to properly register subnodes when mapping over launchplans.
Signed-off-by: Yee Hing Tong <[email protected]>
|
Bito Automatic Review Skipped - Branch Excluded |
cosmicBboy
requested review from
davidmirror-ops,
eapolinario,
kumare3,
pingsutw and
samhita-alla
as code owners
cosmicBboy
merged commit 04af7e4
into
bugfix/enable-notebook-registration
|
Bito Automatic Review Skipped - Branch Excluded |
* [wip] enable notebook registration Signed-off-by: Niels Bantilan <[email protected]> * lint Signed-off-by: Niels Bantilan <[email protected]> * updates (#3276) * updates * makes sense now Signed-off-by: Yee Hing Tong <[email protected]> --------- Signed-off-by: Yee Hing Tong <[email protected]> --------- Signed-off-by: Niels Bantilan <[email protected]> Signed-off-by: Yee Hing Tong <[email protected]> Co-authored-by: Yee Hing Tong <[email protected]>
* [wip] enable notebook registration Signed-off-by: Niels Bantilan <[email protected]> * lint Signed-off-by: Niels Bantilan <[email protected]> * updates (flyteorg#3276) * updates * makes sense now Signed-off-by: Yee Hing Tong <[email protected]> --------- Signed-off-by: Yee Hing Tong <[email protected]> --------- Signed-off-by: Niels Bantilan <[email protected]> Signed-off-by: Yee Hing Tong <[email protected]> Co-authored-by: Yee Hing Tong <[email protected]> Signed-off-by: Atharva <[email protected]>
Tracking issue
Why are the changes needed?
What changes were proposed in this pull request?
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link