Ignore ray reinit errors in local execution #3277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ziemin
requested review from
cosmicBboy,
davidmirror-ops,
eapolinario,
kumare3,
pingsutw,
samhita-alla and
wild-endeavor
as code owners
|
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
Member
|
@Ziemin Can you please sign off your commits |
Signed-off-by: Marcin Ziemiński <[email protected]>
Ziemin
force-pushed
the
ray-local-execution-ignore-reinit
branch
from
ad91a0c to
217e9b4
Compare
kumare3
approved these changes
Jun 16, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3277 +/- ##
===========================================
- Coverage 83.35% 52.52% -30.84%
===========================================
Files 347 215 -132
Lines 28791 22520 -6271
Branches 2960 2961 +1
===========================================
- Hits 23999 11828 -12171
- Misses 3956 9974 +6018
+ Partials 836 718 -118 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fiedlerNr9
approved these changes
Jun 22, 2025
|
Congrats on merging your first pull request! 🎉 |
Atharva1723
pushed a commit
to Atharva1723/flytekit
that referenced
this pull request
Oct 5, 2025
Signed-off-by: Marcin Ziemiński <[email protected]> Signed-off-by: Atharva <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Why are the changes needed?
During local execution workflows using multiple Ray tasks fail, because every task attempts to create a fresh ray instance. This PR simply sets turns on the flag to ignore ray re-initialization errors.
What changes were proposed in this pull request?
Ray init params contain
ignore_reinit_errorset toTruewhen executing locally.How was this patch tested?
Tested this code version both locally and on flyte cluster with workflows using multiple ray tasks.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link
Summary by Bito
This pull request enhances the Ray initialization process by adding a parameter to ignore reinitialization errors during local workflow execution. This improvement increases the reliability and stability of workflows that involve multiple Ray tasks.