make ngc image secret optional #3280
Conversation
Signed-off-by: Samhita Alla <[email protected]>
|
Bito Automatic Review Skipped - Draft PR |
Signed-off-by: Samhita Alla <[email protected]>
samhita-alla
requested review from
cosmicBboy,
davidmirror-ops,
eapolinario,
kumare3,
pingsutw and
wild-endeavor
as code owners
Signed-off-by: Samhita Alla <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3280 +/- ##
===========================================
- Coverage 83.35% 52.78% -30.57%
===========================================
Files 347 218 -129
Lines 28791 22715 -6076
Branches 2960 2961 +1
===========================================
- Hits 23999 11991 -12008
- Misses 3956 10006 +6050
+ Partials 836 718 -118 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
need a code owner review as well. @cosmicBboy would you mind reviewing the PR? |
* remove image pull secret Signed-off-by: Samhita Alla <[email protected]> * make it optional Signed-off-by: Samhita Alla <[email protected]> * update docstring Signed-off-by: Samhita Alla <[email protected]> --------- Signed-off-by: Samhita Alla <[email protected]> Signed-off-by: Atharva <[email protected]>
Tracking issue
Why are the changes needed?
these changes are required for the private registry support we rolled out with image spec. if
ngc_image_secretis specified, we still go the old route. if the user provides the image pull secret as a secret and adds builder options to the image spec, we don't need to specify the image pull secret in the pod template.What changes were proposed in this pull request?
made
ngc_image_secretoptional.How was this patch tested?
tested the NIM plugin by specifying the image pull secret as a flyte secret and adding it to imagespec.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link
Summary by Bito
This pull request enhances the NIM plugin by making the 'ngc_image_secret' parameter optional and introducing new builder options for improved private registry support, while maintaining compatibility with the old method. These changes aim to streamline the configuration process for users.