Fix launch plan CLI registration #3285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gistration - Check if launch plan already exists before attempting workflow registration - Return existing launch plan if found to avoid unnecessary operations - Add debug logging for better troubleshooting - Include debugging print statements for CLI flow analysis 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
pingsutw
requested review from
cosmicBboy,
davidmirror-ops,
eapolinario,
kumare3,
samhita-alla and
wild-endeavor
as code owners
Signed-off-by: Kevin Su <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3285 +/- ##
===========================================
- Coverage 79.87% 52.43% -27.45%
===========================================
Files 250 215 -35
Lines 24046 22473 -1573
Branches 2967 2966 -1
===========================================
- Hits 19207 11783 -7424
- Misses 3990 9972 +5982
+ Partials 849 718 -131 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
wild-endeavor
approved these changes
Jun 30, 2025
pingsutw
changed the title
This was referenced Jun 30, 2025
Atharva1723
pushed a commit
to Atharva1723/flytekit
that referenced
this pull request
Oct 5, 2025
Signed-off-by: Kevin Su <[email protected]> Co-authored-by: Claude <[email protected]> Signed-off-by: Atharva <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes a small change to the
register_scriptmethod inflytekit/remote/remote.py. The change sets theversionattribute ofserialization_settingsbefore proceeding with entity registration.This pull request includes a minor update to theregister_scriptmethod inflytekit/remote/remote.py. The change assigns theversionto theserialization_settingsobject before registering the entity.Test plan
🤖 Generated with Claude Code
Summary by Bito
This pull request enhances the launch plan registration process by checking for existing plans before registration and removing unnecessary debug print statements. It introduces debug logging for better execution insights and clarifies comments related to workflow registration, improving code readability and maintainability. These changes contribute to a more efficient and reliable CLI operation.