Fix click option parameter declaration to remove short flag conflict #3286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove -i short flag from poll_interval parameter to avoid conflicts with other CLI options that may use the same short flag. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
pingsutw
requested review from
cosmicBboy,
davidmirror-ops,
eapolinario,
kumare3,
samhita-alla and
wild-endeavor
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3286 +/- ##
==========================================
+ Coverage 49.31% 52.55% +3.23%
==========================================
Files 369 215 -154
Lines 29804 22539 -7265
Branches 2967 2967
==========================================
- Hits 14698 11845 -2853
+ Misses 14993 9971 -5022
- Partials 113 723 +610 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
wild-endeavor
approved these changes
Jul 2, 2025
Atharva1723
pushed a commit
to Atharva1723/flytekit
that referenced
this pull request
Oct 5, 2025
…lyteorg#3286) Remove -i short flag from poll_interval parameter to avoid conflicts with other CLI options that may use the same short flag. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-authored-by: Claude <[email protected]> Signed-off-by: Atharva <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
-ishort flag frompoll_intervalparameter to avoid conflicts with other CLI optionsit will remove the click warning from cli
Test plan
--poll-intervalparameter functions correctly🤖 Generated with Claude Code
Summary by Bito
This pull request resolves a conflict in the CLI options by removing the short flag '-i' from the 'poll_interval' parameter, ensuring the '--poll-interval' option works correctly. The changes enhance CLI usability while preserving existing functionality.