add ephemeral storage param to nim #3291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Samhita Alla <[email protected]>
samhita-alla
requested review from
cosmicBboy,
davidmirror-ops,
eapolinario,
kumare3,
pingsutw and
wild-endeavor
as code owners
Contributor
Author
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3291 +/- ##
===========================================
+ Coverage 52.55% 79.47% +26.91%
===========================================
Files 215 215
Lines 22545 22545
Branches 2969 2969
===========================================
+ Hits 11849 17918 +6069
+ Misses 9972 3777 -6195
- Partials 724 850 +126 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cosmicBboy
approved these changes
Jul 15, 2025
Atharva1723
pushed a commit
to Atharva1723/flytekit
that referenced
this pull request
Oct 5, 2025
Signed-off-by: Samhita Alla <[email protected]> Signed-off-by: Atharva <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Why are the changes needed?
This PR adds
ephemeral-storageto the model server's requests and limits. The goal is to make it configurable at the user level.What changes were proposed in this pull request?
Adds
ephemeral_storageto the sidecar template and sets it to20Gifor the NIM model server.How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link
Summary by Bito
This pull request enhances the model server's configuration by introducing an `ephemeral_storage` parameter, allowing users to specify storage requirements. The change is implemented in both the model server and sidecar template files, with a default value of `20Gi` for improved resource management.