image builder: give flytekit user ownership of /root after venv is cr… #3298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eated Signed-off-by: Niels Bantilan <[email protected]>
cosmicBboy
requested review from
davidmirror-ops,
eapolinario,
kumare3,
pingsutw,
samhita-alla and
wild-endeavor
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3298 +/- ##
===========================================
- Coverage 88.77% 77.06% -11.72%
===========================================
Files 115 215 +100
Lines 4866 22548 +17682
Branches 0 2969 +2969
===========================================
+ Hits 4320 17376 +13056
- Misses 546 4302 +3756
- Partials 0 870 +870 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ursucarina
approved these changes
Jul 16, 2025
kumare3
approved these changes
Jul 16, 2025
Atharva1723
pushed a commit
to Atharva1723/flytekit
that referenced
this pull request
Oct 5, 2025
…eated (flyteorg#3298) Signed-off-by: Niels Bantilan <[email protected]> Signed-off-by: Atharva <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where the
flytekituser in the default image builder doesn't have read/write access to the virtual environment in/root/.venv. This is important in cases where the user wants to install additional packages/add additional files to the virtual environment.Summary by Bito
This pull request resolves a critical issue by granting the `flytekit` user ownership permissions for the `/root` directory and its home directory. This enhancement allows for the installation of additional packages and improved file management within the virtual environment at `/root/.venv`, thereby increasing the usability of the default image builder.