[Core feature] Reuse same literals in the dynamic task #3307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Barry Wu <[email protected]>
BarryWu0812
requested review from
cosmicBboy,
davidmirror-ops,
eapolinario,
kumare3,
pingsutw,
samhita-alla and
wild-endeavor
as code owners
…ache Signed-off-by: Barry Wu <[email protected]>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3307 +/- ##
===========================================
- Coverage 85.26% 44.97% -40.29%
===========================================
Files 386 319 -67
Lines 30276 26812 -3464
Branches 2969 2953 -16
===========================================
- Hits 25814 12060 -13754
- Misses 3615 14655 +11040
+ Partials 847 97 -750 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Barry Wu <[email protected]>
machichima
reviewed
Aug 6, 2025
popojk
reviewed
Aug 6, 2025
Signed-off-by: Barry Wu <[email protected]>
machichima
reviewed
Aug 8, 2025
pingsutw
reviewed
Aug 8, 2025
pingsutw
reviewed
Aug 8, 2025
Signed-off-by: Barry Wu <[email protected]>
machichima
reviewed
Aug 15, 2025
Member
machichima
left a comment
machichima
left a comment
There was a problem hiding this comment.
Overall LGTM! Thank you!
Just some nit
Signed-off-by: Barry Wu <[email protected]>
Signed-off-by: Barry Wu <[email protected]>
machichima
reviewed
Aug 22, 2025
Signed-off-by: Barry Wu <[email protected]>
Co-authored-by: Nary Yeh <[email protected]>
pingsutw
reviewed
Aug 27, 2025
Signed-off-by: Barry Wu <[email protected]>
pingsutw
approved these changes
Sep 19, 2025
Atharva1723
pushed a commit
to Atharva1723/flytekit
that referenced
this pull request
Oct 5, 2025
Signed-off-by: Barry Wu <[email protected]> Co-authored-by: Kevin Su <[email protected]> Co-authored-by: Nary Yeh <[email protected]> Signed-off-by: Atharva <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Closes flyteorg/flyte#6032
Why are the changes needed?
We should only serialize the variable and upload it once to reuse the same input.
To make the same Python value reuse the literal.
What changes were proposed in this pull request?
Add a local cache to store the literal that has been serialized.
How was this patch tested?
Unit test
Check all the applicable boxes
Summary by Bito
This pull request enhances the Flyte framework by implementing a local caching mechanism using an LRU cache for serialized literals, replacing the previous cache. This improvement boosts efficiency by reducing redundant serialization and uploads of identical Python values. A new unit test has been added to verify caching behavior when pandas is unavailable, and existing unit tests have been updated to ensure the new caching behavior is validated.