IDL upper bound #3321
Merged
IDL upper bound #3321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yee Hing Tong <[email protected]>
wild-endeavor
requested review from
cosmicBboy,
davidmirror-ops,
eapolinario,
kumare3,
pingsutw and
samhita-alla
as code owners
EngHabu
previously approved these changes
Aug 22, 2025
| "docker>=4.0.0", | ||
| "docstring-parser>=0.9.0", | ||
| "flyteidl>=1.15.4b0", | ||
| "flyteidl>=1.15.4b0,<2.0.0a0", |
Collaborator
There was a problem hiding this comment.
Is it not enough to say <2.0.0?
Contributor
Author
There was a problem hiding this comment.
if we release a 2.0.0aX it'll still get picked up... according to gpt
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
pingsutw
approved these changes
Aug 23, 2025
Atharva1723
pushed a commit
to Atharva1723/flytekit
that referenced
this pull request
Oct 5, 2025
Signed-off-by: Yee Hing Tong <[email protected]> Signed-off-by: Atharva <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an upper bound to Flyte IDL. Exclude even alpha releases.
Summary by Bito
This pull request introduces an upper bound to the Flyte IDL dependency in both the pyproject.toml and Dockerfile.dev files, enhancing stability by excluding potentially unstable alpha releases. The changes focus on effective dependency management and are straightforward, making the review process relatively simple.