Skip to content

Conversation

@machichima
Copy link
Member

@machichima machichima commented Aug 24, 2025

Tracking issue

Why are the changes needed?

Docker builds were extremely slow due to transferring 8.8GB of build context, including the large .venv/ directory, .git/ Python cache files, and other development artifacts. Adding .dockerignore reduces context transfer to ~160MB, significantly speeding up integration test container builds.

  • Before:
image
  • After:
image

What changes were proposed in this pull request?

Add .dockerignore file to exclude development artifacts from Docker build context. Refer .dockerignore file setting here: https://gist.github.com/KernelA/04b4d7691f28e264f72e76cfd724d448

How was this patch tested?

Running make build-dev to ensure the context size is reduced

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Summary by Bito

This pull request introduces a .dockerignore file that optimizes Docker builds by excluding unnecessary files, reducing the context size from 8.8GB to approximately 160MB. This enhancement significantly improves the speed of integration test container builds and streamlines the development process.

@codecov
Copy link

codecov bot commented Aug 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 52.52%. Comparing base (bcdfaae) to head (dc109e2).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3323      +/-   ##
==========================================
- Coverage   52.64%   52.52%   -0.13%     
==========================================
  Files         215      215              
  Lines       22543    22473      -70     
  Branches     2950     2949       -1     
==========================================
- Hits        11868    11804      -64     
+ Misses       9968     9967       -1     
+ Partials      707      702       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

-e
Signed-off-by: machichima <[email protected]>
@machichima machichima force-pushed the optimize-integration-test-setup branch from dc109e2 to e0ae32d Compare August 27, 2025 04:13
@flyte-bot
Copy link
Contributor

Bito Automatic Review Failed - Technical Failure

Bito encountered technical difficulties while generating code feedback . To retry, type /review in a comment and save. If the issue persists, contact [email protected] and provide the following details:

Agent Run ID: 16ce39d0-fc27-4835-8743-a097d27af329

@pingsutw pingsutw merged commit 4922dbe into flyteorg:master Aug 29, 2025
115 checks passed
Atharva1723 pushed a commit to Atharva1723/flytekit that referenced this pull request Oct 5, 2025
Signed-off-by: machichima <[email protected]>
Signed-off-by: Atharva <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants