Add escape hatch for reference entities in remote._get_image_names #3341
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
There's an issue with using reference launch plans. This fix added images to the automatic version calculation so that
ImageSpecs that effectively changed would result in a new version, but this shouldn't happen for reference entities.If you register the following
and then try to
pyflyte runthe followingyou get
What changes were proposed in this pull request?
Skip reference entities in the
_get_image_namesfunction.Also fixing the type-hint. Since the function recursively calls workflow nodes, all types can be called.
How was this patch tested?
Tested on by running against remote cluster.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link