Skip to content

Check and access metaclass error_code property properly #3349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
machichima merged 3 commits into from
Nov 10, 2025
Merged

Check and access metaclass error_code property properly #3349

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b68d416
Check metaclass error_code property properly
andresgomezfrr Nov 5, 2025
2a63313
Fix
andresgomezfrr Nov 5, 2025
74d89e0
fix lint
andresgomezfrr Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions flytekit/exceptions/user.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,12 @@ def value(self):

@property
def error_code(self):
return self.value.error_code if hasattr(self.value, "error_code") else self._ERROR_CODE

if hasattr(self.value, "error_code"):
return self.value.error_code
elif hasattr(type(self.value), "error_code"):
return type(self.value).error_code
else:
return self._ERROR_CODE

class FlyteTypeException(FlyteUserException, TypeError):
_ERROR_CODE = "USER:TypeError"
Expand Down
17 changes: 11 additions & 6 deletions tests/flytekit/unit/bin/test_python_entrypoint.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
from flytekit.exceptions import user as user_exceptions
from flytekit.exceptions.base import FlyteException
from flytekit.exceptions.scopes import system_entry_point
from flytekit.exceptions.user import FlyteRecoverableException, FlyteUserRuntimeException
from flytekit.exceptions.user import FlyteRecoverableException, FlyteUserRuntimeException, FlyteUserException
from flytekit.models import literals as _literal_models
from flytekit.models.core import errors as error_models, execution
from flytekit.models.core import execution as execution_models
Expand Down Expand Up @@ -128,19 +128,24 @@ def verify_output(*args, **kwargs):
_dispatch_execute(ctx, lambda: python_task, "inputs path", "outputs prefix")
assert mock_write_to_file.call_count == 1

class CustomException(FlyteUserException):
_ERROR_CODE = "USER:CustomError"

@pytest.mark.parametrize(
"exception_value",
[
FlyteException("exception", timestamp=1),
FlyteException("exception"),
Exception("exception"),
[FlyteException("exception", timestamp=1), FlyteException.error_code],
[FlyteException("exception"), FlyteException.error_code],
[Exception("exception"), FlyteUserRuntimeException.error_code],
[CustomException("exception"), CustomException.error_code],
]
)
@mock.patch("flytekit.core.utils.load_proto_from_file")
@mock.patch("flytekit.core.data_persistence.FileAccessProvider.get_data")
@mock.patch("flytekit.core.data_persistence.FileAccessProvider.put_data")
@mock.patch("flytekit.core.utils.write_proto_to_file")
def test_dispatch_execute_exception_with_multi_error_files(mock_write_to_file, mock_upload_dir, mock_get_data, mock_load_proto, exception_value: Exception, monkeypatch):
def test_dispatch_execute_exception_with_multi_error_files(mock_write_to_file, mock_upload_dir, mock_get_data, mock_load_proto, exception_value: typing.Tuple[Exception, str], monkeypatch):
exception_value, error_code = exception_value
monkeypatch.setenv("_F_DES", "1")
monkeypatch.setenv("_F_WN", "worker")

Expand Down Expand Up @@ -170,7 +175,7 @@ def verify_output(*args, **kwargs):
assert error_filename_base.startswith("error-")
uuid.UUID(hex=error_filename_base[6:], version=4)
assert error_filename_ext == ".pb"
assert container_error.code == "USER:RuntimeError"
assert container_error.code == error_code

mock_write_to_file.side_effect = verify_output
_dispatch_execute(ctx, lambda: python_task, "inputs path", "outputs prefix")
Expand Down
Loading