Skip to content

Secrets fallback #3359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wild-endeavor wants to merge 2 commits into from
Closed

Secrets fallback #3359

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d51c98
add debugging prints
wild-endeavor Dec 23, 2025
a046147
add a temporary fix to unblock
wild-endeavor Dec 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions flytekit/core/context_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,6 +402,10 @@ def get(
if ctx.execution_state is None or ctx.execution_state.is_local_execution():
env_prefixes.append("")

# Temporary fix to always check for the default prefix
if "_FSEC_" not in env_prefixes:
env_prefixes.append("_FSEC_")

for env_prefix in env_prefixes:
env_var = self._get_secrets_env_var(
group=group, key=key, group_version=group_version, env_prefix=env_prefix
Expand All @@ -414,6 +418,7 @@ def get(
if os.path.exists(fpath):
with open(fpath, encode_mode) as f:
return f.read().strip()

raise ValueError(
f"Please make sure to add secret_requests=[Secret(group={group}, key={key})] in @task. Unable to find secret for key {key} in group {group} "
f"in Env Var:{env_var} and FilePath: {fpath}"
Expand Down
Loading