fix(cache purge): ensure cache URL path ends with a trailing slash

[ma-04]

Fixes https://github.com/flywp/flywp-app/issues/1031

Summary by CodeRabbit

• Bug Fixes
  • Improved cache purging reliability by ensuring URL paths are consistently formatted with a trailing slash, resulting in more accurate cache management.

[coderabbitai]

Walkthrough

The purge_cache_by_url method in the Fastcgi_Cache class was updated to ensure that the URL path used for cache key generation always ends with a trailing slash. This normalization occurs before hashing, potentially altering which cache files are purged.

Changes

File(s)	Change Summary
includes/Fastcgi_Cache.php	Modified purge_cache_by_url to append a trailing slash to the URL path before cache key hash.

Poem

In the warren of cache, a path did stray,
Lacking a slash at the end of its way.
Now every burrowed URL is neat,
With a trailing slash to make it complete.
So rabbits can hop, with caches purged right—
Paths all aligned, day or night!
🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9be24f8 and d98ef64.

📒 Files selected for processing (1)

• includes/Fastcgi_Cache.php (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• includes/Fastcgi_Cache.php

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 33b71ed and 9be24f8.

📒 Files selected for processing (1)

• includes/Fastcgi_Cache.php (1 hunks)

🧰 Additional context used

🪛 GitHub Check: Run PHPCS inspection

includes/Fastcgi_Cache.php

[failure] 125-125:
No space before closing parenthesis is prohibited

---

[failure] 125-125:
Expected 1 spaces before closing parenthesis; 0 found

---

[failure] 125-125:
Expected 1 spaces after opening parenthesis; 0 found

---

[failure] 125-125:
No space after opening parenthesis is prohibited

---

[failure] 123-123:
Whitespace found at end of line

🪛 GitHub Actions: Inspections

includes/Fastcgi_Cache.php

[warning] 1-1: This comment is 58% valid code; is this commented out code?

---

[warning] 1-1: This comment is 58% valid code; is this commented out code?

---

[error] 1-1: Whitespace found at end of line

🔇 Additional comments (1)

includes/Fastcgi_Cache.php (1)

124-127: LGTM! Cache key normalization logic is correct.

The logic properly ensures URL paths end with trailing slashes, which will fix cache inconsistencies where URLs with and without trailing slashes generated different cache keys. The implementation correctly handles edge cases including empty paths.

🧰 Tools

🪛 GitHub Check: Run PHPCS inspection

[failure] 125-125:
No space before closing parenthesis is prohibited

---

[failure] 125-125:
Expected 1 spaces before closing parenthesis; 0 found

---

[failure] 125-125:
Expected 1 spaces after opening parenthesis; 0 found

---

[failure] 125-125:
No space after opening parenthesis is prohibited

[itsrafsanjani]

LGTM