Draft
Conversation
Contributor
Author
|
Back in the oven since it relies on a dccrg update that has been invalidated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft for an improved post-refinement VDF filtering scheme, brought in line with fsgrid filtering in order to avoid "banding" from refined cells dropping filtering passes on fsgrid. Also does a zero-length acceleration time step after refinement so
_Vmoments are correct, both for coarsened cells and filtered cells.Requires fmihpc/dccrg#48 for finding cells at smaller offset.
TODO:
P::filterPassesshould ideally be based on fsgrid filtering passes