Update Compute to use provider::service syntax#155
Open
sethboyles wants to merge 1 commit intofog:masterfrom
Open
Update Compute to use provider::service syntax#155sethboyles wants to merge 1 commit intofog:masterfrom
sethboyles wants to merge 1 commit intofog:masterfrom
Conversation
Authored-by: Seth Boyles <sboyles@pivotal.io>
johha
added a commit
to cloudfoundry/cloud_controller_ng
that referenced
this pull request
Jun 5, 2024
Seems to be no longer needed with fog-core >= 2.3.0 References: - fog/fog-core#269 - fog/fog-aliyun#155
|
This PR is not required anymore. We've tested cloudfoundry/cloud_controller_ng#3744 on an AliCloud landscape and found no issues. We also did a counter test and inserted this hack again: and then we received this error: So the workaround is really not required anymore. |
philippthun
pushed a commit
to cloudfoundry/cloud_controller_ng
that referenced
this pull request
Sep 6, 2024
* build(deps): bump fog-core from 2.1.2 to 2.4.0 Bumps [fog-core](https://github.com/fog/fog-core) from 2.1.2 to 2.4.0. - [Changelog](https://github.com/fog/fog-core/blob/master/changelog.md) - [Commits](fog/fog-core@v2.1.2...v2.4.0) --- updated-dependencies: - dependency-name: fog-core dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Remove fog aliyun hack Seems to be no longer needed with fog-core >= 2.3.0 References: - fog/fog-core#269 - fog/fog-aliyun#155 --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Johannes Haass <johannes.haass@sap.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When upgrading to fog-core 2.1, we see a lot of errors like this:
Updating the syntax should resolve this and make
fog-aliyuncompatible with fog-core 2.1