New function giving syntax error in 2.0x ruby#65
Open
mariohmol wants to merge 3 commits intofog:masterfrom
Open
New function giving syntax error in 2.0x ruby#65mariohmol wants to merge 3 commits intofog:masterfrom
mariohmol wants to merge 3 commits intofog:masterfrom
Conversation
shiramax
approved these changes
Apr 18, 2019
Contributor
shiramax
left a comment
shiramax
left a comment
There was a problem hiding this comment.
Seems good to me,
@orrabin, @ShimShtein One of you can review as well?
ShimShtein
requested changes
Apr 21, 2019
Collaborator
ShimShtein
left a comment
ShimShtein
left a comment
There was a problem hiding this comment.
Indeed, required kwargs were introduced in ruby 2.1, so it's an invalid syntax for 2.0.
guard conditions for create_search_by_datacenter
shiramax
suggested changes
Oct 29, 2019
Co-authored-by: Shira Maximov <mshira@redhat.com>
Author
|
Sorry, didnt see this request, for me its ok! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this will fix this #64
thanks