Update error handling to use body message instead of reason phrase #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manisha15
force-pushed
the
fix_error_handling
branch
from
625d8b9 to
89dd5b5
Compare
sbernhard
reviewed
Jul 28, 2025
| raise(Fog::Errors::NotFound) | ||
| end | ||
| rescue StandardError | ||
| raise e |
There was a problem hiding this comment.
whats the reason to to just re-raise an exception? is the exception handling then useful?
sbernhard
reviewed
Jul 28, 2025
| @@ -53,10 +53,16 @@ def get(id) | |||
| status_data = service.get_server_status path_params | |||
| config_data = service.get_server_config path_params | |||
| rescue StandardError => e | |||
| if e.respond_to?('response') && e.response.respond_to?('data') && e.response.data.has_key?(:reason_phrase) && e.response.data[:reason_phrase].end_with?('does not exist') | |||
| raise(Fog::Errors::NotFound) | |||
| if e.respond_to?('response') && e.response.respond_to?('data') && e.response.data.has_key?(:body) | |||
There was a problem hiding this comment.
handling body additionally, might be useful - but we still should catch the reason_pharse, too?
There was a problem hiding this comment.
As I explained in #108, the reason phrase should not be used for anything. It might be overwritten by intermediate servers or completely discarded.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #108