Open
Conversation
Author
|
Sorry, I forgot to mention that I also implemented the option to set a scale factor for the x/y output so that when creating lithophanes one can more easily scale a picture down or adapt the resolution of image pixels (usually 1:1) to the of the printer (usually != 1:1) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I suggest a (maybe simple) cmake file. This is a bit more modern and easier to maintain than a classical handwritten makefile and can more easily check for the existence of the dependencies. I also added what is required to create binary packages (.tar.gz and debian packages). Not really important, but also easy to do.
In addition, instead of turning off compiler warnings, I have fixed the warning and left out the compiler switch from cmake's input. These were mainly two warnings: comparison between signed and unsigned in loops (I replaced int with the correct size_t) and redeclaration of variable names in local context (I added an underscore before the local ones)