Skip to content

Conversation

@pkjacob
Copy link
Contributor

@pkjacob pkjacob commented Dec 23, 2025

Mark import as failed when no resources are imported

@github-actions
Copy link

Jest Unit Test Results

0 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit 7aed81c. ± Comparison against base commit 982a5e7.

@sonarqubecloud
Copy link

Copy link
Contributor

@zepheiryan zepheiryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to me like it should either be a special case or not considered a problem.

Whether uploading a file with nothing in it or a file with only duplicates of existing resources, there are no correctable errors encountered from the round trip from front to back to front again. This seems like success: “we did exactly what you asked.” If we think an empty log or log full of duplicate notices isn't explicit enough, then “we did exactly what you asked but it was an empty graph” seems more appropriate than “we failed and you should look into what went wrong” - there’s nothing the user can actually change to get a different outcome.

@pkjacob
Copy link
Contributor Author

pkjacob commented Dec 23, 2025

This seems to me like it should either be a special case or not considered a problem.

Whether uploading a file with nothing in it or a file with only duplicates of existing resources, there are no correctable errors encountered from the round trip from front to back to front again. This seems like success: “we did exactly what you asked.” If we think an empty log or log full of duplicate notices isn't explicit enough, then “we did exactly what you asked but it was an empty graph” seems more appropriate than “we failed and you should look into what went wrong” - there’s nothing the user can actually change to get a different outcome.

Thank You. I will look into this next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants