fix(actions): preserve count1 across async actions (Fixes #668) #677
+17
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added `count1` to trouble.Action.ctx. This allows actions to use `count1` because of originally the context from `vim.v.count1` is lost because of the `:next` call on the view.
DragonXexe
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where the
next,prev,first,last,fold_reduceandfold_morewould not be correctly affected byv:count1.That was caused by the fact that these actions were called asynchronously. Because of that Neovim seems to reset the command specific context including
count1.How To Test
3]]or any other action with another count.Description
This PR preserves
count1by passing it in the context of each action.This will fix the issue and will also make the documentation, which states that these actions can use count, correct.
Related Issue(s)
Fixes #668