Skip to content

[Popup] Misaligned positioning when parent has scrollbar #1918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
lubber-de wants to merge 4 commits into
base: develop
Choose a base branch
from
Draft

[Popup] Misaligned positioning when parent has scrollbar #1918

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a8162e6
fix(popup): correct positioning for parent margins
lubber-de Mar 18, 2021
eb87aa0
Merge branch 'develop' into fix/1899/popupRightPositionBodyMargin
lubber-de May 16, 2021
96ded3f
Merge branch 'develop' into fix/1899/popupRightPositionBodyMargin
lubber-de Mar 19, 2023
94270ba
feat(popup): linting fixes
lubber-de Mar 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/definitions/modules/popup.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -820,7 +820,12 @@ $.fn.popup = function(parameters) {
if(searchDepth == settings.maxSearchDepth && typeof settings.lastResort === 'string') {
position = settings.lastResort;
}

if(position === 'top right' || position === 'bottom right') {
var possibleMargin = calculations.boundary.right - calculations.parent.width;
if(possibleMargin > 0) {
offset -= possibleMargin;
}
}
switch (position) {
case 'top left':
positioning = {
Expand Down