feat(header): rename to heading #3200
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lubber-de
added
lang/css
lubber-de
added
the
state/awaiting-docs
ko2in
reviewed
Mar 14, 2025
Member
ko2in
left a comment
ko2in
left a comment
There was a problem hiding this comment.
The following themes still have old file names header.overrides and header.variables:
- classic
- github
- material
Member
Author
Member
|
LGTM. |
# Conflicts: # src/themes/classic/collections/table.variables # src/themes/github/collections/menu.variables
# Conflicts: # src/definitions/elements/heading.less
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As discussed in #2407 this PR renames
headertoheading..ui.headerselectors to.ui.heading@header...LESS variables to@heading...headingas well (so header.less and header.variables dont exists anymore)A new variation variable is introduced:
@variationHeadingLegacyHeader(default false)When set to true, it will generate the old
.headerclasses in addition to the.headingclasses for easier migration (but will double all selectors which increases css filesize)This is a HUGE BREAKING CHANGE as
@header...variables as those do not exist anymoretheme.configand each customsemantic.jsonheaderusages are replaced byheadingclass usagesStill to be decided / taken into consideration
I leave this PR as draft for now as we still have to check/decide how to deal with other "header" usages in other components:
thtag in a table is still a "header", not a "heading". However the table component shares the same@headingvariables as the heading element itself. This is inconsistent, i think there are dedicated new variables neededheader(which either is a "heading", a "title" or still a "header"If this gets merged, we may announce all upcoming breaking changes (espcially this one) long before 2.10.0 gets released, so people are prepared.