Fix incorrect JSON source for item_defect_minimum_spacing#318
Fix incorrect JSON source for item_defect_minimum_spacing#318fontanf merged 2 commits intofontanf:masterfrom
Conversation
Read item_defect_minimum_spacing from json_defect instead of json_item.
|
Hi, Thank you for the contribution. It looks good. Do you think you could include a unit test by adding corresponding instance/expected solution files like here https://github.com/fontanf/packingsolver/tree/master/data/irregular/tests and adding them as test at the end of this file https://github.com/fontanf/packingsolver/blob/master/test/irregular/irregular_test.cpp ? Otherwise, I'll try to do it myself later |
|
Hi, Thank you for the review. I can provide the instance JSON file that exposed the issue (the one you shared earlier). instance.json Since the change only corrects the JSON source for a single parameter, I wasn't entirely sure how such tests are usually structured in this project. If you prefer to add the test on your side, that would also be perfectly fine for me. Best regards |
|
Please integrate the test if you can. As I mentioned above, you just need to solve the problem to get the solution file, store both the instance and the solution files in data/irregular/tests, add the corresponding test at the end of test/irregular/irregular_test.cpp, and run the tests with |
Read item_defect_minimum_spacing from json_defect instead of json_item.