fix: issue creating microsoft.fontspectorplugin #164
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ollimeier
changed the title
Collaborator
Author
|
@simoncozens I am closing this, as it's not relevant for me anymore. I don't use the microsoft-profil and don't want to double check after so long if this is still a proper code modification or not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Relates to issue #163
This is a draft PR, because I am not confident enough to say that this is actually a fix. With these changes I am able to create a microsoft.fontspectorplugin file. But when I do:
fontspector --plugins microsoft.fontspectorplugin --profile microsoft a-font-file.ttf --html test.htmlI get this in the terminal:
Checklist
CHANGELOG.md