refactor(fontwerk/names.rs): replace get_name_PEL_codes and get_name_entry_string #480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@simoncozens I am wondering how we would like to proceed with this PR? |
Collaborator
Author
|
@simoncozens Any news on that? |
…entry_string + fix uniitest (because of different sorting of platform _tuples)
ollimeier
force-pushed
the
issue-474-refactor-fontwerk-name_entries
branch
from
07244fe to
004fd1b
Compare
Collaborator
Author
|
@simoncozens I have fixed the conflict. From my point of view this can be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Relates to issue #474
Refactor code by replacing
get_name_PEL_codesandget_name_entry_stringwith general function stored in fontspector_checkapi (which we recently added, that why this is a follow-up)This is a draft PR, because I am wondering if we would like to move "fontwerk/name_entries" to universal. If not, this PR is ready for review.