use on_setattr to auto-convert dict to Lib and Kerning#188
Draft
anthrotype wants to merge 1 commit intomainfrom
Draft
use on_setattr to auto-convert dict to Lib and Kerning#188anthrotype wants to merge 1 commit intomainfrom
anthrotype wants to merge 1 commit intomainfrom
Conversation
This was referenced Dec 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One can use
on_setattr=attrs.setters.converton a field that has an attrs converter defined (e.g. Font.lib or Glyph.lib) to run the field converter whenever the attribute is set, not just at default constructor time.It's a nice feature, allows to remove the property getter/setter boilerplate, and it's actually a bit faster to get/set the field compared to the properties.
But mypy doesn't like it.. python-attrs/attrs#889