Skip to content

Fixes(#1) cramming of commands #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
azimux merged 4 commits into from
Nov 14, 2025
Merged

Fixes(#1) cramming of commands #2

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7318f89
Fixes(#1) cramming of commands
klnsv Nov 13, 2025
48a88e3
bumped ruby version
klnsv Nov 13, 2025
d821ed4
removed spaces between HTML tags
klnsv Nov 13, 2025
d249e0f
added li tag outside the helper(#1)
klnsv Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .ruby-version
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
3.4.5
3.4.7
2 changes: 1 addition & 1 deletion src/http/commands/help/presenter.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ def render_html_list(data, skip_wrapper: false)
def foobara_reference_link(manifest)
path = "/help/#{manifest.reference}"

"<a href=\"#{path}\">#{manifest.reference.split("::").last}</a>"
"<li><a href=\"#{path}\">#{manifest.reference.split("::").last}</a></li>"
Copy link
Contributor

@azimux azimux Nov 14, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should relocate this to line 153 since that's where these commands are rendered and are missing their <li> tags, as opposed to here which might be called outside of a context where an <li> is needed.

end

def root_manifest
Expand Down