Updated test to save/retrieve large values #2763
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test no longer creates large strings (neither before writing nor after reading). That is however insufficient to avoid the OOM since the underlying implementation read all the bytes in memory for encryption/decryption. So I lowered the size of the test data. NB: I did attempt to implement a memory-efficient kv-store using CipherOutputStream and CipherInputStream (see 047def6) - it was noticeably slower - it also caused OOMs ! Maybe Android's Conscrypt AES-GCM cipher implementation has internal buffering !! ??
Contributor
Author
|
NB: The one failure is a flapper in a different lib. |
brandonpage
approved these changes
Sep 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test no longer creates large strings (neither before writing nor after reading).
That is however insufficient to avoid the OOM since the underlying implementation read all the bytes in memory for encryption/decryption. So I lowered the size of the test data.
NB: I did attempt to implement a memory-efficient kv-store using CipherOutputStream and CipherInputStream (see wmathurin@047def6)