Saving scope in user account #2776
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
wmathurin
commented
Sep 30, 2025
wmathurin
commented
- token end point response contains scope
- this value is now captured and saved in the user account
- tests were updated
- token end point response contains scope - this value is now captured and saved in the user account - tests were updated
Generated by 🚫 Danger |
brandonpage
approved these changes
Oct 1, 2025
| * | ||
| * @return Array of scope strings (empty if scope is null/empty). | ||
| */ | ||
| public String[] parseScopes() { |
Contributor
There was a problem hiding this comment.
I find Lists to be a lot easier to deal with than Arrays, especially in Kotlin. Seems like the List contains function would be useful for scopes, but you could call contains() on the String scope itself as well so really not a big deal.
Edit: Apparently I should have just kept reading, hasScope resolves the above.
Contributor
Author
|
Only test failure (LoginActivityTest.viewModelIsUsingFrontDoorBridge_DefaultValue_onCreateWithoutQrCodeLoginIntent) is related to changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.