Skip to content

Conversation

@wmathurin
Copy link
Contributor

Added tests for the new method (inspectScope)
Also refactored setCookies to make it more testable and added tests

…e missing

Added tests for the new method (inspectScope)
Also refactored setCookies to make it more testable and added tests
@wmathurin wmathurin requested a review from bbirman October 7, 2025 01:14
@codecov
Copy link

codecov bot commented Oct 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.37%. Comparing base (7d868cd) to head (62ebdf7).
⚠️ Report is 17 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff            @@
##                dev    #2779   +/-   ##
=========================================
  Coverage     56.36%   56.37%           
- Complexity     2479     2491   +12     
=========================================
  Files           211      211           
  Lines         17145    17155   +10     
  Branches       2376     2381    +5     
=========================================
+ Hits           9664     9671    +7     
- Misses         6435     6439    +4     
+ Partials       1046     1045    -1     
Components Coverage Δ
Analytics 47.92% <ø> (ø)
SalesforceSDK 44.11% <ø> (-0.03%) ⬇️
Hybrid 58.67% <100.00%> (+0.61%) ⬆️
SmartStore 78.20% <ø> (ø)
MobileSync 79.23% <ø> (ø)
React 46.94% <ø> (-0.70%) ⬇️
Files with missing lines Coverage Δ
...dsdk/phonegap/ui/SalesforceWebViewCookieManager.kt 93.05% <100.00%> (+3.76%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@JohnsonEricAtSalesforce JohnsonEricAtSalesforce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@wmathurin
Copy link
Contributor Author

Tests are passing. Not sure why SalesforceReact coverage regressed.

@wmathurin wmathurin merged commit eb7462e into forcedotcom:dev Oct 7, 2025
17 of 18 checks passed
@wmathurin wmathurin changed the title Hybrid app inspect scopes on user agent and warn if important ones are missing Hybrid app inspect scopes on user account and warn if important ones are missing Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants