Shard Tests #2809
Merged
Shard Tests #2809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #2809 +/- ##
=========================================
Coverage 61.77% 61.77%
Complexity 2767 2767
=========================================
Files 214 214
Lines 16931 16931
Branches 2453 2453
=========================================
Hits 10459 10459
Misses 5306 5306
Partials 1166 1166
🚀 New features to boost your workflow:
|
wmathurin
approved these changes
Dec 2, 2025
brandonpage
commented
Dec 2, 2025
.github/test-shards/README.md
Outdated
|
|
||
| Each confiruration file defines targets using the `class` keyword. To ensure all tests are run, each config has a "remaining" shard that **only** uses the `notClass` keyword. New test classes will automatically be included in the "remaining" shard. | ||
|
|
||
| However, it is very important that classes added to shards are also added to the "remaining" shard to prevent them from running twice. Likewise it is important that classes removed from shards are also removed from the "remaining" shard so they are not skipped. |
Contributor
Author
There was a problem hiding this comment.
I will write a trust story to ensure this is maintained. It shouldn't be too hard to write a bash script that ensure the number of targets in the "remaining" shard exactly equals the number of targets in all other shards combined.
But I would like to see the system be proven to be useful before adding additional work.
Edit: Implemented. With name matching, to prevent typos and make fixing mistakes easier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should significantly reduce the time it takes for our tests to run since all shards run in parallel. I have done my best to anticipate any possible collisions that could cause test failures. Each lib has a "remaining" shard with only
notClasstargets (from the other shards) so it will run everything not in another shard. No work is required when adding new tests.