AuthFlowTester App #2821
Open
AuthFlowTester App #2821
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
brandonpage
commented
Jan 16, 2026
| /** | ||
| * String extension to convert to [ScopeParser]. | ||
| */ | ||
| fun String?.toScopeParser(): ScopeParser = ScopeParser(scopeString = this) |
Contributor
Author
There was a problem hiding this comment.
One of only a few SDK changes. This (and Array<String>?.toScopeParameter() below) seemed like they maybe convenient for customers so I created them as public API but I could move them to the sample app if we want.
brandonpage
commented
Jan 16, 2026
Comment on lines
+335
to
+340
| showDevSupport?.let { | ||
| MenuItem(stringResource(sf__dev_support_title_menu_item)) { | ||
| it.invoke() | ||
| showMenu = false | ||
| } | ||
| } |
Job Summary for GradlePull Request :: test-android
|
brandonpage
commented
Jan 16, 2026
Comment on lines
+169
to
+170
| // UserAccount's equals() function only compares userId and orgId. | ||
| policy = neverEqualPolicy(), |
Contributor
Author
There was a problem hiding this comment.
It took me longer than I care to admit to figure out this is why the UI wasn't updating when the user's token was updated. 😅
brandonpage
commented
Jan 16, 2026
Comment on lines
+175
to
+189
| // Set current user when it changes to update UI. | ||
| DisposableEffect(Unit) { | ||
| val receiver = object : BroadcastReceiver() { | ||
| override fun onReceive(context: Context, intent: Intent) { | ||
| currentUser.value = UserAccountManager.getInstance().currentUser | ||
| } | ||
| } | ||
| val filter = IntentFilter(UserAccountManager.USER_SWITCH_INTENT_ACTION) | ||
| filter.addAction(ClientManager.ACCESS_TOKEN_REFRESH_INTENT) | ||
| filter.addAction(ClientManager.INSTANCE_URL_UPDATE_INTENT) | ||
| ContextCompat.registerReceiver(context, receiver, filter, ContextCompat.RECEIVER_NOT_EXPORTED) | ||
| onDispose { | ||
| context.unregisterReceiver(receiver) | ||
| } | ||
| } |
Contributor
Author
There was a problem hiding this comment.
I liked this a bit more than the UUID refreshTrigger on iOS.
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (35.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## dev #2821 +/- ##
============================================
+ Coverage 62.10% 62.32% +0.22%
Complexity 2789 2789
============================================
Files 215 215
Lines 16993 16950 -43
Branches 2474 2423 -51
============================================
+ Hits 10553 10564 +11
+ Misses 5263 5208 -55
- Partials 1177 1178 +1
🚀 New features to boost your workflow:
|
Contributor
Author
|
The missing code coverage seems to be entirely UI code I can't reasonably get to 😞. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the new AuthFlowTester App, which is almost identical to its iOS counterpart except for a few details:
Redirect Uri- not stored on Android (unused on iOS)Protocol- included inDomainon AndroidIdentifierJWT- unused on iOSAuth Code- unused on iOSChallenge- unused on iOSIssued AtAPI Url- iOS uses this as the SFAP URL.Fallback (MSDK) color scheme for API < 31
Dynamic OS Provided Color Scheme Examples
This PR is almost entirely sample app code and includes a new UI test that utilizes code from our UITests repo. Additional test be added in a subsequent PR.
I have also held back on including the "Migrate to New App" feature as that feature requires new SDK code. I have that code fully functional but will hold it for a follow-up to make this PR easier to consume.