Skip to content

Hybrid app inspect scopes in user credentials and warn if important ones are missing#284

Merged
wmathurin merged 2 commits intoforcedotcom:devfrom
wmathurin:zero_scopes
Oct 15, 2025
Merged

Hybrid app inspect scopes in user credentials and warn if important ones are missing#284
wmathurin merged 2 commits intoforcedotcom:devfrom
wmathurin:zero_scopes

Conversation

@wmathurin
Copy link
Copy Markdown
Contributor

  • Added tests for the new method (inspectScope)
  • Latest from iOS submodule
  • Latest from shared submodule

…nes are missing

Added tests for the new method (inspectScope)
Latest from iOS submodule
Latest from shared submodule
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 14, 2025

Codecov Report

❌ Patch coverage is 75.92593% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.39%. Comparing base (100136c) to head (d88e75b).
⚠️ Report is 8 commits behind head on dev.

Files with missing lines Patch % Lines
...idSDK/Classes/SalesforceWebViewCookieManager.swift 75.92% 13 Missing ⚠️

❌ Your patch status has failed because the patch coverage (75.92%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #284      +/-   ##
==========================================
+ Coverage   58.78%   61.39%   +2.61%     
==========================================
  Files          21       21              
  Lines        1776     1816      +40     
==========================================
+ Hits         1044     1115      +71     
+ Misses        732      701      -31     
Flag Coverage Δ
SalesforceFileLogger 60.38% <ø> (ø)
SalesforceHybridSDK 61.60% <75.92%> (+3.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...idSDK/Classes/SalesforceWebViewCookieManager.swift 69.00% <75.92%> (+69.00%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@wmathurin
Copy link
Copy Markdown
Contributor Author

The code coverage is a bit misleading - the method had zero coverage before. Now it's refactored with the bulk of the code in a method that is covered. And code coverage is looking at the non-covered part of the new code and complaining about it.

@wmathurin wmathurin merged commit 57f835c into forcedotcom:dev Oct 15, 2025
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants