Hybrid app inspect scopes in user credentials and warn if important ones are missing#284
Merged
wmathurin merged 2 commits intoforcedotcom:devfrom Oct 15, 2025
Merged
Conversation
Contributor
wmathurin
commented
Oct 14, 2025
- Added tests for the new method (inspectScope)
- Latest from iOS submodule
- Latest from shared submodule
…nes are missing Added tests for the new method (inspectScope) Latest from iOS submodule Latest from shared submodule
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (75.92%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## dev #284 +/- ##
==========================================
+ Coverage 58.78% 61.39% +2.61%
==========================================
Files 21 21
Lines 1776 1816 +40
==========================================
+ Hits 1044 1115 +71
+ Misses 732 701 -31
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Added tests for setCookies
bbirman
approved these changes
Oct 15, 2025
Contributor
Author
|
The code coverage is a bit misleading - the method had zero coverage before. Now it's refactored with the bulk of the code in a method that is covered. And code coverage is looking at the non-covered part of the new code and complaining about it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.