Skip to content

Removing unused directory#285

Merged
wmathurin merged 4 commits intoforcedotcom:devfrom
wmathurin:dev
Oct 20, 2025
Merged

Removing unused directory#285
wmathurin merged 4 commits intoforcedotcom:devfrom
wmathurin:dev

Conversation

@wmathurin
Copy link
Copy Markdown
Contributor

No description provided.

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.28%. Comparing base (d88e75b) to head (4f86f97).
⚠️ Report is 6 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #285      +/-   ##
==========================================
- Coverage   61.39%   61.28%   -0.12%     
==========================================
  Files          21       21              
  Lines        1816     1816              
==========================================
- Hits         1115     1113       -2     
- Misses        701      703       +2     
Flag Coverage Δ
SalesforceFileLogger 60.38% <ø> (ø)
SalesforceHybridSDK 61.47% <ø> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bbirman
Copy link
Copy Markdown
Member

bbirman commented Oct 17, 2025

Could you check on these references in the project files too? I was wondering about them before but dropped it since we were close to cutting 13.1

@wmathurin wmathurin requested a review from bbirman October 20, 2025 20:33
@bbirman
Copy link
Copy Markdown
Member

bbirman commented Oct 20, 2025

I think there are more in AccountEditor, MobileSyncExplorerHybrid, and the xcconfig the framework uses. I only noticed before because they show up as build warnings like search path '/Users/brianna.birman/SalesforceMobileSDK-iOS-Hybrid/external/ThirdPartyDependencies/sqlcipher' not found

@wmathurin wmathurin merged commit 18e5e5b into forcedotcom:dev Oct 20, 2025
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants