Pointing to head of master for submodule SalesforceMobileSDK-iOS

[wmathurin]

No description provided.

[wmathurin]

Weird, I don't understand why the diff is empty

[brandonpage]

I was just about to ask about this!

[wmathurin]

forcedotcom/SalesforceMobileSDK-iOS@fe97c22 is the head of master for SalesfoceMobileSDK-iOS though.

[wmathurin]

My commit from an hour ago had the submodule point to a non-existent commit.
Click on SalesforceMobileSDK-iOS on this page: https://github.com/wmathurin/SalesforceMobileSDK-iOS-Hybrid/tree/1523e5d3b83d1761ab3e633a64ab40dd4bb3ce8e/external

But now it seems to be fixed.
Click on SalesforceMobileSDK-iOS on this page: https://github.com/wmathurin/SalesforceMobileSDK-iOS-Hybrid/tree/19735e57c1082eee9de8c405f12a503f334696d6/external

[bbirman]

I think maybe it's because the new base from the last PR https://github.com/forcedotcom/SalesforceMobileSDK-iOS/commits/d2de03486920a5e48ec49b1c945fc319266af7c3 isn't found?

I can see a diff if I use the base from #286 and the new head from here: forcedotcom/SalesforceMobileSDK-iOS@5983758...fe97c22

edit: agreed on @wmathurin's comment!

[wmathurin]

Not sure how that happened !! I think I had not initialized the submodules on my local clone ??

[wmathurin]

So I think this PR is good ?

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.78%. Comparing base (cafbb5c) to head (19735e5).
⚠️ Report is 49 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #288      +/-   ##
==========================================
- Coverage   58.96%   58.78%   -0.18%     
==========================================
  Files          22       21       -1     
  Lines        1791     1776      -15     
==========================================
- Hits         1056     1044      -12     
+ Misses        735      732       -3     

Flag	Coverage Δ
SalesforceFileLogger	60.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1 file with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.