Deprecating sharedProcessPool in SFSDKWebViewStateManager #3933
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- WKProcessPool creation has no effect since iOS 15, so we are no longer using it - sharedProcessPool will be removed in MSDK 14 from SFSDKWebViewStateManager (at which points the deprecation warnings will disappear) - also removed SFSDKWebViewStateManager.h and SFSDKWebViewStateManager.m which are no longer used since the class was converted to swift a while back but were still in the repo
Clang Static Analysis Issues
Generated by 🚫 Danger |
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (66.66%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## dev #3933 +/- ##
==========================================
- Coverage 63.52% 63.47% -0.05%
==========================================
Files 250 250
Lines 22501 22494 -7
==========================================
- Hits 14293 14278 -15
- Misses 8208 8216 +8
🚀 New features to boost your workflow:
|
iosdroid
approved these changes
Sep 22, 2025
bbirman
approved these changes
Sep 22, 2025
bbirman
reviewed
Oct 7, 2025
| } | ||
|
|
||
|
|
||
| @available(*, deprecated, message: "Deprecated in Salesforce Mobile SDK 13.1 and will be removed in Salesforce Mobile SDK 14.0. WKProcessPool creation has no effect on iOS 15+ and this property will be removed.") |
Contributor
Author
There was a problem hiding this comment.
You're right. I'll send another PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sharedProcessPoolwill be removed in MSDK 14 fromSFSDKWebViewStateManager(at which points the deprecation warnings will disappear).WKProcessPoolcreation has no effect since iOS 15, so we are no longer using it.Also removed
SFSDKWebViewStateManager.handSFSDKWebViewStateManager.mwhich should have been removed when the class was converted to Swift a while back.