Fix related to flapping test #3937
Conversation
|
|
||
| CFRelease(privateKeyRef); | ||
| if (decryptedData == nil) { | ||
| if (decryptedData == nil || [decryptedData length] != 32) { |
There was a problem hiding this comment.
From the comment in the flapping test (below), starting in 17.4 decrypting with a bad key returns data instead of nil so at the time I just changed our expected error in the test. But it looks like that data is also variable length (in my runs locally it was 72, 54, and 15). When the data length is less than 32, lines 209 or 210 crash so adding a length check before that
| } | ||
| // As of 17.4, decrypting a bad key with PKCS1 returns data instead of nil, so the secret decryption doesn't fail | ||
| // at the same point as before but using it later to decrypt the content still fails | ||
| XCTAssert(nonRSASecretError.code == SFSDKPushNotificationErrorContentDecryptionFailed || nonRSASecretError.code == SFSDKPushNotificationErrorSecretDecryptionFailed); |
There was a problem hiding this comment.
I kept the check for both errors in case there's a chance that the bad data is 32 long and passes the check but still fails to decrypt later
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #3937 +/- ##
==========================================
- Coverage 63.50% 63.48% -0.02%
==========================================
Files 250 250
Lines 22501 22501
==========================================
- Hits 14289 14285 -4
- Misses 8212 8216 +4
🚀 New features to boost your workflow:
|
2 participants
No description provided.