Saving scopes with rest of credentials

[wmathurin]

• token end point response contains scopes
• this value is now captured and saved with credentials
• tests were updated
• also showing scopes in dev info

[github-actions]

	1 Warning
⚠️	Static Analysis found an issue with one or more files you modified. Please fix the issue(s).

Clang Static Analysis Issues

File	Type	Category	Description	Line	Col
SFOAuthCredentials	Dereference of null pointer	Logic error	Access to instance variable '_credentialsChangeSet' results in a dereference of a null pointer (loaded from variable 'self')	194	27
SFOAuthCredentials	Nullability	Memory error	nil passed to a callee that requires a non-null 1st parameter	297	20
SalesforceSDKManager	Nil value used as mutex for @synchronized() (no synchronization will occur)	Logic error	Nil value used as mutex for @synchronized() (no synchronization will occur)	144	5
SalesforceSDKManager	Nil value used as mutex for @synchronized() (no synchronization will occur)	Logic error	Nil value used as mutex for @synchronized() (no synchronization will occur)	156	5

Generated by 🚫 Danger

[bbirman]

Could it go into SFOAuthCredentials+Internal.h for unit tests?
edit: I got confused by the comment, it's readonly?

[wmathurin]

We have the same comments all over the file.
They are very old (seems to date from 61a9e26#diff-b278b72952b2a17bb9191443c53295ad580cf65c013cfacc1bc44d06e59acb82R100-R101).
I'll remove it since it is readonly in the public header and only readwrite in the internal header.

[codecov]

Codecov Report

❌ Patch coverage is 93.33333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 63.48%. Comparing base (c83d097) to head (c16a7f6).
⚠️ Report is 3 commits behind head on dev.

Files with missing lines	Patch %	Lines
...forceSDKCore/Classes/Common/SalesforceSDKManager.m	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##              dev    #3941      +/-   ##
==========================================
+ Coverage   63.46%   63.48%   +0.01%     
==========================================
  Files         250      250              
  Lines       22493    22506      +13     
==========================================
+ Hits        14276    14288      +12     
- Misses       8217     8218       +1     

Components	Coverage Δ
Analytics	70.78% <ø> (ø)
Common	70.58% <ø> (-0.52%)	⬇️
Core	53.95% <93.33%> (+0.07%)	⬆️
SmartStore	73.66% <ø> (ø)
MobileSync	87.66% <ø> (ø)

Files with missing lines	Coverage Δ
...lesforceSDKCore/Classes/OAuth/SFOAuthCredentials.m	96.45% <100.00%> (+0.10%)	⬆️
...DKCore/SalesforceSDKCore/SFOAuthCredentialsTests.m	100.00% <100.00%> (ø)
...orceSDKCore/SFSDKOAuthTokenEndpointResponseTests.m	100.00% <100.00%> (ø)
...forceSDKCore/Classes/Common/SalesforceSDKManager.m	57.71% <0.00%> (-0.12%)	⬇️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.