Skip to content

Conversation

@bbirman
Copy link
Member

@bbirman bbirman commented Nov 4, 2025

Follow up to #3940, was going through the test plan against dev and realized I should've pushed these before

@github-actions
Copy link

github-actions bot commented Nov 4, 2025

1 Warning
⚠️ Static Analysis found an issue with one or more files you modified. Please fix the issue(s).

Clang Static Analysis Issues

File Type Category Description Line Col
SFUserAccountManager Nullability Memory error Null passed to a callee that requires a non-null 2nd parameter 1496 15
SFUserAccountManager Nullability Memory error Null passed to a callee that requires a non-null 2nd parameter 1511 15
SFUserAccountManager Nullability Memory error nil passed to a callee that requires a non-null 2nd parameter 2143 13

Generated by 🚫 Danger

@codecov
Copy link

codecov bot commented Nov 4, 2025

Codecov Report

❌ Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.81%. Comparing base (362007b) to head (71acdb5).
⚠️ Report is 25 commits behind head on dev.

Files with missing lines Patch % Lines
...SDKCore/Classes/UserAccount/SFUserAccountManager.m 0.00% 6 Missing ⚠️
...re/Classes/Login/LoginHost/SFSDKLoginHostStorage.m 0.00% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3948      +/-   ##
==========================================
- Coverage   62.96%   62.81%   -0.16%     
==========================================
  Files         249      249              
  Lines       21701    21703       +2     
==========================================
- Hits        13665    13632      -33     
- Misses       8036     8071      +35     
Components Coverage Δ
Analytics 70.78% <ø> (ø)
Common 69.76% <ø> (ø)
Core 52.91% <0.00%> (-0.25%) ⬇️
SmartStore 73.99% <ø> (ø)
MobileSync 87.41% <ø> (ø)
Files with missing lines Coverage Δ
...re/Classes/Login/LoginHost/SFSDKLoginHostStorage.m 61.25% <0.00%> (ø)
...SDKCore/Classes/UserAccount/SFUserAccountManager.m 38.90% <0.00%> (+0.08%) ⬆️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bbirman bbirman merged commit c3b9d38 into forcedotcom:dev Nov 4, 2025
19 of 24 checks passed
@bbirman bbirman deleted the settings-follow-up branch November 4, 2025 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants