Skip to content

Surface network error for actionable notifications #3953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bbirman merged 1 commit into from
Nov 21, 2025

Surface network error for actionable notifications

27bf5db
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Surface network error for actionable notifications #3953

Surface network error for actionable notifications
27bf5db
Select commit
Loading
Failed to load commit list.
GitHub Actions / SalesforceSDKCore iOS ^18 failed Nov 21, 2025 in 0s

Xcode test results

Testing workspace SalesforceMobileSDK with scheme SalesforceSDKCore

Summary

TotalSuccess PassedFailure FailedSkipped SkippedExpected Failure Expected Failure⏱️ Time
58558410011.17s

Test Summary

SalesforceSDKCoreTests

  • Device: iPhone 16 Pro, 18.6 (22G86)
  • SDK: Simulator - iOS 18.5, 18.5
TestTotalSuccessFailureSkippedExpected Failure
test-class ActionTypeTests66000
test-class AuthFlowTypesViewTests11000
test-class BiometricAuthenticationManagerTests88000
test-class BootConfigPickerViewControllerTests44000
test-class BootconfigTests2020000
test-class CryptoUtilsTests11000
test-class DecryptStreamTests1212000
test-class DevInfoViewControllerTests2727000
test-class DomainDiscoveryCoordinatorTests88000
test-class EncryptStreamTests1313000
test-class EncryptionTests66000
test-class JwtAccessTokenTests33000
test-class NSString_SFAdditionsTests33000
test-class NSURL_SFStringUtilsTests55000
test-class NativeLoginManagerTests55000
test-class NewLoginHostTests44000
test-class NotificationCategoryFactoryTests22000
test-class PushNotificationDecryptionTests22000
test-class PushNotificationManagerTests3535000
test-class RestClientPublisherTests44000
test-class RestClientTests2222000
test-class RestClientWebSocketTests11000
test-class SDKCommonNSDataTests22000
test-class SDSDKAlertMessageTest33000
test-class SFEncryptionKeyTests22000
test-class SFManagedPreferencesTest22000
test-class SFNetworkTests22000
test-class SFOAuthCoordinatorTests22000
test-class SFOAuthCredentialsTests44000
test-class SFOAuthInfoTests22000
test-class SFOAuthSessionRefresherTests22000
test-class SFPreferencesTests44000
test-class SFPushNotificationManagerTests44000
test-class SFSDKAppFeatureMarkersTests33000
test-class SFSDKAuthConfigUtilTests55000
test-class SFSDKAuthErrorCommandTest33000
test-class SFSDKAuthRequestCommandTest33000
test-class SFSDKAuthUtilTests55000
test-class SFSDKCryptoUtilsTests1212000
test-class SFSDKEncryptedPushNotificationTests1616000
test-class SFSDKErrorManagerTests55000
test-class SFSDKIDPAuthCodeLoginRequestCommandTest11000
test-class SFSDKIDPLoginRequestCommandTest33000
test-class SFSDKKeyValueEncryptedFileStoreTests2222000
test-class SFSDKLoginHostTests55000
test-class SFSDKOAuthTokenEndpointResponseTests11000
test-class SFSDKSPLoginResponseCommandTest33000
test-class SFSDKSalesforceAnalyticsManagerTests22000
test-class SFSDKURLHandlerManagerTest1111000
test-class SFSDKUrlCacheTests66000
test-class SFSDKWindowManagerTests1414000
test-class SFUserAccountManagerNotificationsTests55000
test-class SFUserAccountManagerPersisterTests55000
test-class SFUserAccountManagerTests1515000
test-class SFUserAccountPhotoTests22000
test-class SFUserIdUpgradeTests11000
test-class SalesforceOAuthUnitTests1212000
test-class SalesforceRestAPITests109108100
test-class SalesforceSDKIdentityTests11000
test-class SalesforceSDKManagerTests4848000
test-class ScopeParserTests88000
test-class ScreenLockManagerTests66000
test-class UIColor_SFColorsTests88000
test-class URLRequestRestRequestTests99000
test-class URLSessionTaskRetryPolicyTests77000
test-class WebSocketClientTests55000
test-class WebViewStateManagerTests33000

Failure Failures

SalesforceSDKCoreTests/SalesforceRestAPITests/testUpdateWithIfUnmodifiedSince

File/Users/runner/work/SalesforceMobileSDK-iOS/SalesforceMobileSDK-iOS/libs/SalesforceSDKCore/SalesforceSDKCoreTests/SalesforceRestAPITests.m:663
Issue TypeAssertion Failure
Message((listener.lastError.code) equal to (412)) failed: ("400") is not equal to ("412") - request should have returned a 412
File/Users/runner/work/SalesforceMobileSDK-iOS/SalesforceMobileSDK-iOS/libs/SalesforceSDKCore/SalesforceSDKCoreTests/SalesforceRestAPITests.m:669
Issue TypeUncaught Exception
Message-[__NSArrayM objectForKeyedSubscript:]: unrecognized selector sent to instance 0x600000d06b20 (NSInvalidArgumentException)

Details

Test Details

SalesforceSDKCoreTestsback

ActionTypeTests back

SuccessFailureSkippedExpected Failure⏱️
6 (100%)0 (0%)0 (0%)0 (0%)0.01s

All tests passed 🎉

AuthFlowTypesViewTests back

SuccessFailureSkippedExpected Failure⏱️
1 (100%)0 (0%)0 (0%)0 (0%)2.17s

All tests passed 🎉

BiometricAuthenticationManagerTests back

SuccessFailureSkippedExpected Failure⏱️
8 (100%)0 (0%)0 (0%)0 (0%)0.02s

All tests passed 🎉

BootConfigPickerViewControllerTests back

SuccessFailureSkippedExpected Failure⏱️
4 (100%)0 (0%)0 (0%)0 (0%)0.01s

All tests passed 🎉

BootconfigTests back

SuccessFailureSkippedExpected Failure⏱️
20 (100%)0 (0%)0 (0%)0 (0%)0.00s

All tests passed 🎉

CryptoUtilsTests back

SuccessFailureSkippedExpected Failure⏱️
1 (100%)0 (0%)0 (0%)0 (0%)0.16s

All tests passed 🎉

DecryptStreamTests back

SuccessFailureSkippedExpected Failure⏱️
12 (100%)0 (0%)0 (0%)0 (0%)0.00s

All tests passed 🎉

DevInfoViewControllerTests back

SuccessFailureSkippedExpected Failure⏱️
27 (100%)0 (0%)0 (0%)0 (0%)0.00s

All tests passed 🎉

DomainDiscoveryCoordinatorTests back

SuccessFailureSkippedExpected Failure⏱️
8 (100%)0 (0%)0 (0%)0 (0%)0.01s

All tests passed 🎉

EncryptStreamTests back

SuccessFailureSkippedExpected Failure⏱️
13 (100%)0 (0%)0 (0%)0 (0%)0.00s

All tests passed 🎉

EncryptionTests back

SuccessFailureSkippedExpected Failure⏱️
6 (100%)0 (0%)0 (0%)0 (0%)0.36s

All tests passed 🎉

JwtAccessTokenTests back

SuccessFailureSkippedExpected Failure⏱️
3 (100%)0 (0%)0 (0%)0 (0%)0.00s

All tests passed 🎉

NSString_SFAdditionsTests back

SuccessFailureSkippedExpected Failure⏱️
3 (100%)0 (0%)0 (0%)0 (0%)0.00s

All tests passed 🎉

NSURL_SFStringUtilsTests back

SuccessFailureSkippedExpected Failure⏱️
5 (100%)0 (0%)0 (0%)0 (0%)0.00s

All tests passed 🎉

NativeLoginManagerTests back

SuccessFailureSkippedExpected Failure⏱️
5 (100%)0 (0%)0 (0%)0 (0%)0.00s

All tests passed 🎉

NewLoginHostTests back

SuccessFailureSkippedExpected Failure⏱️
4 (100%)0 (0%)0 (0%)0 (0%)0.00s

All tests passed 🎉

NotificationCategoryFactoryTests back

SuccessFailureSkippedExpected Failure⏱️
2 (100%)0 (0%)0 (0%)0 (0%)0.40s

All tests passed 🎉

PushNotificationDecryptionTests back

SuccessFailureSkippedExpected Failure⏱️
2 (100%)0 (0%)0 (0%)0 (0%)0.07s

All tests passed 🎉

PushNotificationManagerTests back

SuccessFailureSkippedExpected Failure⏱️
35 (100%)0 (0%)0 (0%)0 (0%)0.00s

All tests passed 🎉

RestClientPublisherTests back

SuccessFailureSkippedExpected Failure⏱️
4 (100%)0 (0%)0 (0%)0 (0%)5.04s

All tests passed 🎉

RestClientTests back

SuccessFailureSkippedExpected Failure⏱️
22 (100%)0 (0%)0 (0%)0 (0%)0.09s

All tests passed 🎉

RestClientWebSocketTests back

SuccessFailureSkippedExpected Failure⏱️
1 (100%)0 (0%)0 (0%)0 (0%)0.00s

All tests passed 🎉

SDKCommonNSDataTests back

SuccessFailureSkippedExpected Failure⏱️
2 (100%)0 (0%)0 (0%)0 (0%)0.00s

All tests passed 🎉

SDSDKAlertMessageTest back

SuccessFailureSkippedExpected Failure⏱️
3 (100%)0 (0%)0 (0%)0 (0%)0.00s

All tests passed 🎉

SFEncryptionKeyTests back

SuccessFailureSkippedExpected Failure⏱️
2 (100%)0 (0%)0 (0%)0 (0%)0.00s

All tests passed 🎉

SFManagedPreferencesTest back

SuccessFailureSkippedExpected Failure⏱️
2 (100%)0 (0%)0 (0%)0 (0%)0.00s

All tests passed 🎉

SFNetworkTests back

SuccessFailureSkippedExpected Failure⏱️
2 (100%)0 (0%)0 (0%)0 (0%)0.02s

All tests passed 🎉

SFOAuthCoordinatorTests back

SuccessFailureSkippedExpected Failure⏱️
2 (100%)0 (0%)0 (0%)0 (0%)0.09s

All tests passed 🎉

SFOAuthCredentialsTests back

SuccessFailureSkippedExpected Failure⏱️
4 (100%)0 (0%)0 (0%)0 (0%)0.02s

All tests passed 🎉

SFOAuthInfoTests back

SuccessFailureSkippedExpected Failure⏱️
2 (100%)0 (0%)0 (0%)0 (0%)0.00s

All tests passed 🎉

SFOAuthSessionRefresherTests back

SuccessFailureSkippedExpected Failure⏱️
2 (100%)0 (0%)0 (0%)0 (0%)0.30s

All tests passed 🎉

SFPreferencesTests back

SuccessFailureSkippedExpected Failure⏱️
4 (100%)0 (0%)0 (0%)0 (0%)0.00s

All tests passed 🎉

SFPushNotificationManagerTests back

SuccessFailureSkippedExpected Failure⏱️
4 (100%)0 (0%)0 (0%)0 (0%)0.00s

All tests passed 🎉

SFSDKAppFeatureMarkersTests back

SuccessFailureSkippedExpected Failure⏱️
3 (100%)0 (0%)0 (0%)0 (0%)0.00s

All tests passed 🎉

SFSDKAuthConfigUtilTests back

SuccessFailureSkippedExpected Failure⏱️
5 (100%)0 (0%)0 (0%)0 (0%)0.06s

All tests passed 🎉

SFSDKAuthErrorCommandTest back

SuccessFailureSkippedExpected Failure⏱️
3 (100%)0 (0%)0 (0%)0 (0%)0.00s

All tests passed 🎉

SFSDKAuthRequestCommandTest back

SuccessFailureSkippedExpected Failure⏱️
3 (100%)0 (0%)0 (0%)0 (0%)0.00s

All tests passed 🎉

SFSDKAuthUtilTests back

SuccessFailureSkippedExpected Failure⏱️
5 (100%)0 (0%)0 (0%)0 (0%)0.00s

All tests passed 🎉

SFSDKCryptoUtilsTests back

SuccessFailureSkippedExpected Failure⏱️
12 (100%)0 (0%)0 (0%)0 (0%)0.00s

All tests passed 🎉

SFSDKEncryptedPushNotificationTests back

SuccessFailureSkippedExpected Failure⏱️
16 (100%)0 (0%)0 (0%)0 (0%)0.00s

All tests passed 🎉

SFSDKErrorManagerTests back

SuccessFailureSkippedExpected Failure⏱️
5 (100%)0 (0%)0 (0%)0 (0%)0.02s

All tests passed 🎉

SFSDKIDPAuthCodeLoginRequestCommandTest back

SuccessFailureSkippedExpected Failure⏱️
1 (100%)0 (0%)0 (0%)0 (0%)0.00s

All tests passed 🎉

SFSDKIDPLoginRequestCommandTest back

SuccessFailureSkippedExpected Failure⏱️
3 (100%)0 (0%)0 (0%)0 (0%)0.00s

All tests passed 🎉

SFSDKKeyValueEncryptedFileStoreTests back

SuccessFailureSkippedExpected Failure⏱️
22 (100%)0 (0%)0 (0%)0 (0%)0.00s

All tests passed 🎉

SFSDKLoginHostTests back

SuccessFailureSkippedExpected Failure⏱️
5 (100%)0 (0%)0 (0%)0 (0%)0.00s

All tests passed 🎉

SFSDKOAuthTokenEndpointResponseTests back

SuccessFailureSkippedExpected Failure⏱️
1 (100%)0 (0%)0 (0%)0 (0%)0.00s

All tests passed 🎉

SFSDKSPLoginResponseCommandTest back

SuccessFailureSkippedExpected Failure⏱️
3 (100%)0 (0%)0 (0%)0 (0%)0.00s

All tests passed 🎉

SFSDKSalesforceAnalyticsManagerTests back

SuccessFailureSkippedExpected Failure⏱️
2 (100%)0 (0%)0 (0%)0 (0%)0.00s

All tests passed 🎉

SFSDKURLHandlerManagerTest back

SuccessFailureSkippedExpected Failure⏱️
11 (100%)0 (0%)0 (0%)0 (0%)0.00s

All tests passed 🎉

SFSDKUrlCacheTests back

SuccessFailureSkippedExpected Failure⏱️
6 (100%)0 (0%)0 (0%)0 (0%)0.00s

All tests passed 🎉

SFSDKWindowManagerTests back

SuccessFailureSkippedExpected Failure⏱️
14 (100%)0 (0%)0 (0%)0 (0%)0.00s

All tests passed 🎉

SFUserAccountManagerNotificationsTests back

SuccessFailureSkippedExpected Failure⏱️
5 (100%)0 (0%)0 (0%)0 (0%)0.01s

All tests passed 🎉

SFUserAccountManagerPersisterTests back

SuccessFailureSkippedExpected Failure⏱️
5 (100%)0 (0%)0 (0%)0 (0%)0.01s

All tests passed 🎉

SFUserAccountManagerTests back

SuccessFailureSkippedExpected Failure⏱️
15 (100%)0 (0%)0 (0%)0 (0%)0.00s

All tests passed 🎉

SFUserAccountPhotoTests back

SuccessFailureSkippedExpected Failure⏱️
2 (100%)0 (0%)0 (0%)0 (0%)2.04s

All tests passed 🎉

SFUserIdUpgradeTests back

SuccessFailureSkippedExpected Failure⏱️
1 (100%)0 (0%)0 (0%)0 (0%)0.01s

All tests passed 🎉

SalesforceOAuthUnitTests back

SuccessFailureSkippedExpected Failure⏱️
12 (100%)0 (0%)0 (0%)0 (0%)0.00s

All tests passed 🎉

SalesforceRestAPITests back

SuccessFailureSkippedExpected Failure⏱️
108 (99%)1 (1%)0 (0%)0 (0%)0.20s
Failuretest-method testUpdateWithIfUnmodifiedSinceback

SalesforceSDKIdentityTests back

SuccessFailureSkippedExpected Failure⏱️
1 (100%)0 (0%)0 (0%)0 (0%)0.00s

All tests passed 🎉

SalesforceSDKManagerTests back

SuccessFailureSkippedExpected Failure⏱️
48 (100%)0 (0%)0 (0%)0 (0%)0.00s

All tests passed 🎉

ScopeParserTests back

SuccessFailureSkippedExpected Failure⏱️
8 (100%)0 (0%)0 (0%)0 (0%)0.00s

All tests passed 🎉

ScreenLockManagerTests back

Annotations

Check failure on line 663 in libs/SalesforceSDKCore/SalesforceSDKCoreTests/SalesforceRestAPITests.m

See this annotation in the file changed.

@github-actions github-actions / SalesforceSDKCore iOS ^18

Assertion Failure 

((listener.lastError.code) equal to (412)) failed: ("400") is not equal to ("412") - request should have returned a 412

Check failure on line 669 in libs/SalesforceSDKCore/SalesforceSDKCoreTests/SalesforceRestAPITests.m

See this annotation in the file changed.

@github-actions github-actions / SalesforceSDKCore iOS ^18

Uncaught Exception 

-[__NSArrayM objectForKeyedSubscript:]: unrecognized selector sent to instance 0x600000d06b20 (NSInvalidArgumentException)
View more details on GitHub Actions