Fix actionable notifications options #3954
Conversation
|
|
||
| private extension PushNotificationManager { | ||
|
|
||
| func createNotificationCategories(from type: NotificationType) -> [UNNotificationCategory] { |
There was a problem hiding this comment.
It looks like the deleted code is duplicative of the methods in NotificationCategoryFactory.swift
There was a problem hiding this comment.
Does NotificationCategoryFactory.shared.createCategories behave differently from the duplicate?
There was a problem hiding this comment.
It returns a set instead of an array but otherwise I didn't see a behavior difference until it calls into createActions. I was wondering if we should keep this and delete NotificationCategoryFactory but that one is public
There was a problem hiding this comment.
Because of semver, we can't do that (in 13.2 at least).
| UNNotificationAction( | ||
| identifier: action.identifier, | ||
| title: action.label, | ||
| options: [.foreground] // Ensures the app opens if needed |
There was a problem hiding this comment.
This is the line causing the issue and the updated logic is already in the other class here
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #3954 +/- ##
==========================================
- Coverage 63.96% 63.34% -0.63%
==========================================
Files 252 252
Lines 22100 22080 -20
==========================================
- Hits 14137 13986 -151
- Misses 7963 8094 +131
🚀 New features to boost your workflow:
|
2 participants
No description provided.