Skip to content

Comments

Add access token revoke request to SDK#3964

Merged
bbirman merged 1 commit intoforcedotcom:devfrom
bbirman:rest-callbacks
Dec 17, 2025
Merged

Add access token revoke request to SDK#3964
bbirman merged 1 commit intoforcedotcom:devfrom
bbirman:rest-callbacks

Conversation

@bbirman
Copy link
Member

@bbirman bbirman commented Dec 17, 2025

No description provided.

/// - Returns: A `RestRequest` object to revoke the access token if access token is present, nil otherwise
@objc
public func requestForRevokeAccessToken(user: UserAccount? = UserAccountManager.shared.currentUserAccount) -> RestRequest? {
guard let user = user ?? UserAccountManager.shared.currentUserAccount,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The currentUser default is here and in the signature so Swift can call it without providing an argument like: 
RestClient.shared.requestForRevokeAccessToken()

and obj-c can call with nil:
[[SFRestAPI sharedInstance] requestForRevokeAccessTokenWithUser:nil]

@github-actions
Copy link

TestsPassed ☑️SkippedFailed ❌️
SalesforceSDKCore iOS ^18 Test Results586 ran584 ✅2 ❌
TestResult
SalesforceSDKCore iOS ^18 Test Results
DomainDiscoveryCoordinatorTests.testCallbackSuccess()❌ failure
SFUserAccountManagerTests.testUserAccountEncoding❌ failure

@codecov
Copy link

codecov bot commented Dec 17, 2025

Codecov Report

❌ Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 61.68%. Comparing base (9f1264e) to head (a44dfc2).
⚠️ Report is 7 commits behind head on dev.

Files with missing lines Patch % Lines
...esforceSDKCore/Classes/Extensions/RestClient.swift 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3964      +/-   ##
==========================================
+ Coverage   61.37%   61.68%   +0.31%     
==========================================
  Files         255      255              
  Lines       22722    22733      +11     
==========================================
+ Hits        13945    14023      +78     
+ Misses       8777     8710      -67     
Components Coverage Δ
Analytics 70.78% <ø> (ø)
Common 70.23% <ø> (ø)
Core 51.83% <90.90%> (+0.49%) ⬆️
SmartStore 73.99% <ø> (ø)
MobileSync 87.41% <ø> (ø)
Files with missing lines Coverage Δ
...esforceSDKCore/Classes/Extensions/RestClient.swift 82.01% <90.90%> (+5.45%) ⬆️

... and 8 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

TestsPassed ☑️SkippedFailed ❌️
SalesforceSDKCore iOS ^26 Test Results586 ran584 ✅2 ❌
TestResult
SalesforceSDKCore iOS ^26 Test Results
BootConfigPickerViewControllerTests.testBootConfigPickerViewRendered()❌ failure
DomainDiscoveryCoordinatorTests.testExtraQueryParameters()❌ failure

@bbirman bbirman merged commit d124a37 into forcedotcom:dev Dec 17, 2025
23 of 27 checks passed
@bbirman bbirman deleted the rest-callbacks branch December 17, 2025 23:23
@bbirman bbirman mentioned this pull request Jan 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants