ci: push-model publish to CBWeb internal marketplace W-21525556#264
ci: push-model publish to CBWeb internal marketplace W-21525556#264peternhale merged 10 commits intomainfrom
Conversation
E2E Test Results SummaryRun: 221 Test Results
Passing Rate by File
ArtifactsView detailed test reports in the Artifacts section. All tests passed |
|
Do you want to remove this job from the nightly workflow in the marketplace repo too? Curious what the size of the vsix you are pushing is, are you doing any sort of pruning for desktop assets first? |
E2E Test Results SummaryRun: 222 Test Results
Passing Rate by File
ArtifactsView detailed test reports in the Artifacts section. All tests passed |
Yes, that's in the follow up to-do's after the merging of this job.
This job wasn't doing any of the pruning. It's taking the packaged vsix generated from the nightly build and publishing it to the internal marketplace. Currently the pruning is done after the fact in the cbweb sync job when it creates the dist, right? Did it need to happen higher up the chain due to the 30s timeout limitation you were mentioning earlier? |
E2E Test Results SummaryRun: 224 Test Results
Passing Rate by File
ArtifactsView detailed test reports in the Artifacts section. All tests passed |
E2E Test Results SummaryRun: 240 Test Results
Passing Rate by File
ArtifactsView detailed test reports in the Artifacts section. All tests passed |
Build a separate web-targeted VSIX with node bundles and source maps stripped, reducing size from ~45MB to ~8MB for Heroku upload limits. Add dry-run guard to create-github-releases job. Made-with: Cursor
E2E Test Results SummaryRun: 241 Test Results
Passing Rate by File
ArtifactsView detailed test reports in the Artifacts section. All tests passed |
E2E Test Results SummaryRun: 268 Test Results
Passing Rate by File
ArtifactsView detailed test reports in the Artifacts section. All tests passed |
jonnyhork
left a comment
jonnyhork
left a comment
There was a problem hiding this comment.
LGTM, so you are planning to have two sets of vsix files or is this only the case when pushing to the internal marketplace?
I looked for a CI run as an example but couldn't find one.
@kylewalke Maybe you already realized this but you are crossing streams here.
yes when bundling CBW the dist does do some pruning after is pulls the VSIX from MS marketplace. I am actually working on refactoring this now, should have no impact on you. |
| needs.package.result == 'success' && | ||
| needs.determine-changes.outputs.selected-extensions != '' && | ||
| github.event_name != 'pull_request' && | ||
| (inputs.dry-run != 'true' && github.event.inputs.dry-run != 'true') |
There was a problem hiding this comment.
@kylewalke please revert the check here for dry-run.
The script that is run is passed the value for dry-run, so it c an do everything in the script, except the final action.
| continue-on-error: true | ||
| if: >- | ||
| needs.package.result == 'success' && | ||
| (inputs.dry-run != 'true' && github.event.inputs.dry-run != 'true') |
There was a problem hiding this comment.
We want all the steps to be exercised, except for the mutating action. Those actions should be guarded with dry-run.
| npx vsce package --target web --no-dependencies | ||
| fi | ||
|
|
||
| WEB_VSIX=$(find . -maxdepth 1 -name "*-web-*.vsix" | head -1) |
There was a problem hiding this comment.
Isn't this simply results of package:packages.vsix.size() - web.vsix.siae()?
There was a problem hiding this comment.
It's just getting the web vsix name. No size calc.
There was a problem hiding this comment.
The line I commented on, ok, but what follows seems relevant to my comment, yes?
There was a problem hiding this comment.
Ah, now I see what you're saying, the calculation in the echo statement. Yes, essentially that is what the difference is. The statement itself is just window dressing so if you want I can remove it as well?
| path: | | ||
| packages/**/*.vsix | ||
| !packages/**/*-web-*.vsix | ||
| packages/**/*.vsix.md5 |
There was a problem hiding this comment.
Should exclude the md5 calculated for the web vsix in step "Generate MD5 checksums"
.github/workflows/package.yml
Outdated
| packages/checksums.json | ||
| retention-days: 5 | ||
|
|
||
| - name: Upload web VSIX artifact |
There was a problem hiding this comment.
Why have a distinct artifact upload when it could be done via step "Upload VSIX artifacts"
E2E Test Results SummaryRun: 280 Test Results
Passing Rate by File
ArtifactsView detailed test reports in the Artifacts section. All tests passed |
E2E Test Results SummaryRun: 286 Test Results
Passing Rate by File
ArtifactsView detailed test reports in the Artifacts section. All tests passed |
E2E Test Results SummaryRun: 289 Test Results
Passing Rate by File
ArtifactsView detailed test reports in the Artifacts section. All tests passed |
E2E Test Results SummaryRun: 292 Test Results
Passing Rate by File
ArtifactsView detailed test reports in the Artifacts section. All tests passed |
3 participants
What does this PR do?
Add
publish-to-cbweb-marketplacejob tonightly-extensions.ymlso the Apex repo pushes the VSIX directly to the internal marketplace after packaging, replacing the current pull model where the marketplace repo fetches from GitHub releases.continue-on-error: true) — marketplace failures never fail the release workflow--retry 2 --retry-delay 5)::error::,::warning::) for visibility in run summariesMARKETPLACE_URLand secretMARKETPLACE_DEPLOY_TOKEN(already configured)What issues does this PR fix or reference?
@W-21525556@