NEW(cpd): @W-16866828@: Implemented the runRules method for CPD (with no configuration yet) #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephen-carter-at-sf
force-pushed
the
sc/CPDImplementation
branch
from
c90d3f8 to
986ddd4
Compare
jfeingold35
reviewed
Nov 8, 2024
stephen-carter-at-sf
force-pushed
the
sc/CPDImplementation
branch
from
65cac4b to
83c0aa9
Compare
stephen-carter-at-sf
force-pushed
the
sc/CPDImplementation
branch
from
83c0aa9 to
f8465bf
Compare
jag-j
reviewed
Nov 11, 2024
...ine/pmd-cpd-wrappers/src/main/java/com/salesforce/sfca/cpdwrapper/CpdLanguageRunResults.java
Show resolved
Hide resolved
jag-j
reviewed
Nov 11, 2024
| @@ -0,0 +1,10 @@ | |||
| function abc3() { | |||
Contributor
There was a problem hiding this comment.
Do you have any non-html files with minimum token greater than the default? Also, can we rename these files a bit more descriptive? Like sampleJavascriptWithLessThanMinTokens.js ?
Contributor
There was a problem hiding this comment.
Ok, I do see some happy path Apex Classes. So, never mind about my first comment. Can we still have the filenames be more descriptive?
Contributor
Author
There was a problem hiding this comment.
Yeah, let me see if I can make the files more descriptive...
jag-j
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
Note that no configuration has been added yet - so the java command, minumumTokens, etc are all just hard coded for now.