CHANGE @W-17042378@ Updated HTML template with comment property. #119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfeingold35
force-pushed
the
d/W-17042378
branch
2 times, most recently
from
3dd4dd2 to
c9cfe64
Compare
jag-j
reviewed
Nov 9, 2024
| class Model { | ||
| constructor(data) { | ||
| (this.violations = this.processViolations(data)), | ||
| constructor(data2) { |
Contributor
There was a problem hiding this comment.
What are these changes about renaming data to data2 ?
Contributor
There was a problem hiding this comment.
It looks like Marcelino made that rename. Josh basically just copied what he got from https://git.soma.salesforce.com/cli-scanner/code-analyzer-report/blob/main/dist/index.html
stephen-carter-at-sf
requested changes
Nov 11, 2024
| class Model { | ||
| constructor(data) { | ||
| (this.violations = this.processViolations(data)), | ||
| constructor(data2) { |
Contributor
There was a problem hiding this comment.
It looks like Marcelino made that rename. Josh basically just copied what he got from https://git.soma.salesforce.com/cli-scanner/code-analyzer-report/blob/main/dist/index.html
| <h1 class="logo">Salesforce</h1> | ||
| <h2 class="title"> | ||
| <strong>Code Analyzer Report</strong> – {{###TIMESTAMP###}} | ||
| <strong>Code Analyzer Report</strong> – Jun 26th, 2024 3:24pm |
Contributor
There was a problem hiding this comment.
Josh - we need to add back in the dynamic timestamp here.
stephen-carter-at-sf
requested changes
Nov 11, 2024
| } | ||
| })(); | ||
| // === START OF VIOLATION DATA === | ||
| const data = [{"rule":"stub1RuleA","engine":"stubEngine1","severity":4,"type":"Standard","tags":["Recommended","CodeStyle"],"file":"test/config.test.ts","line":3,"column":6,"endLine":11,"endColumn":8,"message":"SomeViolationMessage1","resources":["https://example.com/stub1RuleA"]},{"rule":"stub1RuleC","engine":"stubEngine1","severity":3,"type":"Standard","tags":["Recommended","Performance","Custom"],"file":"test/run.test.ts","line":21,"column":7,"endLine":25,"endColumn":4,"message":"SomeViolationMessage2","resources":["https://example.com/stub1RuleC","https://example.com/aViolationSpecificUrl1","https://example.com/violationSpecificUrl2"]},{"rule":"stub1RuleE","engine":"stubEngine1","severity":3,"type":"Standard","tags":["Performance"],"file":"test/run.test.ts","line":56,"column":4,"message":"Some Violation that contains\na new line in `it` and "various" 'quotes'. Also it has <brackets> that may need to be {escaped}.","resources":["https://example.com/stub1RuleE","https://example.com/stub1RuleE_2"]},{"rule":"stub2RuleC","engine":"stubEngine2","severity":2,"type":"DataFlow","tags":["Recommended","BestPractice"],"file":"test/stubs.ts","line":76,"column":8,"primaryLocationIndex":2,"locations":[{"file":"test/stubs.ts","line":4,"column":13},{"file":"test/test-helpers.ts","line":9,"column":1},{"file":"test/stubs.ts","line":76,"column":8}],"message":"SomeViolationMessage3","resources":[]},{"rule":"stub3RuleA","engine":"stubEngine3","severity":3,"type":"Flow","tags":["Recommended","ErrorProne"],"file":"test/stubs.ts","line":90,"column":1,"endLine":95,"endColumn":10,"primaryLocationIndex":2,"locations":[{"file":"test/stubs.ts","line":20,"column":10,"endLine":22,"endColumn":25,"comment":"Comment at location 1"},{"file":"test/test-helpers.ts","line":5,"column":10,"comment":"Comment at location 2"},{"file":"test/stubs.ts","line":90,"column":1,"endLine":95,"endColumn":10}],"message":"SomeViolationMessage4","resources":[]}]; |
Contributor
There was a problem hiding this comment.
Your files like test/config.test.ts should be test{{PATHSEP}}config.test.ts to make this gold file platform independent
stephen-carter-at-sf
approved these changes
Nov 12, 2024
jfeingold35
force-pushed
the
d/W-17042378
branch
from
50228a3 to
80753eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.